Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EIP-7702 #317

Closed
hai-rise opened this issue Sep 4, 2024 · 3 comments
Closed

Support EIP-7702 #317

hai-rise opened this issue Sep 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@hai-rise
Copy link
Contributor

hai-rise commented Sep 4, 2024

Bytecode::Eip7702(_) => unimplemented!("TODO: Support EIP-7702"),

@EdwardJES
Copy link
Contributor

Hey @hai-rise, getting Pectra supported is exciting. How do you expect the EvmCode struct to evolve here? If this is expected to hold all bytecode formats, I think the best path forward would be adopting a similar API to how revm did it: https://github.com/bluealloy/revm/blob/acf1a70ca8350e5144275769262f59a66700a49d/crates/primitives/src/bytecode.rs#L19.

We would then have individual structs per bytecode where we can extend the types.

Did you have a similar pattern in mind?

Ty.

@hai-rise
Copy link
Contributor Author

Hey @hai-rise, getting Pectra supported is exciting. How do you expect the EvmCode struct to evolve here? If this is expected to hold all bytecode formats, I think the best path forward would be adopting a similar API to how revm did it: https://github.com/bluealloy/revm/blob/acf1a70ca8350e5144275769262f59a66700a49d/crates/primitives/src/bytecode.rs#L19.

We would then have individual structs per bytecode where we can extend the types.

Did you have a similar pattern in mind?

Ty.

Yes, and #358 is in the right direction already!

@hai-rise
Copy link
Contributor Author

hai-rise commented Oct 3, 2024

Done in #358.

@hai-rise hai-rise closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants