Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighter read origin validation #353

Open
hai-rise opened this issue Sep 14, 2024 · 3 comments
Open

Tighter read origin validation #353

hai-rise opened this issue Sep 14, 2024 · 3 comments

Comments

@hai-rise
Copy link
Contributor

We currently compare transaction incarnations for validation leading to over-estimation when different incarnations write the same value to the memory location (this could be common). A tradeoff we can try is to store (cloned) read values not to invalidate when the read value hasn't changed. Another heuristic to avoid expensive value comparisons is invalidating when we read from a different transaction now (there's a high chance the value has changed).

@byhashdong
Copy link
Contributor

byhashdong commented Nov 9, 2024

@hai-rise, could you assist by listing the code snippet? I mean which code path need to be improved.

@hai-rise
Copy link
Contributor Author

hai-rise commented Nov 9, 2024

@byhashdong Ah this one is pretty involved. I did a quick PoC in #367 and it didn't improve much if I remember correctly. I'm sure there are many improvements over a 10-min PoC but never had the time to benchmark each variation 😅.

@byhashdong
Copy link
Contributor

Okay, if you need any assistance, please inform me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants