Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open new tab functionality #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

priambudiLB
Copy link

Noticable Changes

  • add new chakra/icon package
  • make ResultBox lazy loaded (only download that component when shown on screen).
Screen.Recording.2021-10-14.at.00.16.16.mov

Resolves #2

@jonathanfilbert
Copy link
Member

Cc: @fahdikrie @althof3

};

const ResultBox = (props: ResultBoxProps) => {
const ristekLink = `https://ristek.link/${props.alias}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const ristekLink = `https://ristek.link/${props.alias}`;
const ristekLink = `${window.location.origin}/${props.alias}`;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated @althof3 ba05775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make initial generated link clickable and opens a new tab
3 participants