fix: tidy parser. add lint/test to makefile. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreulavelle
commented
Mar 2, 2024
| from .overseerr import Overseerr # noqa: F401 | ||
| from .plex_watchlist import PlexWatchlist # noqa: F401 | ||
| from .listrr import Listrr # noqa: F401 |
There was a problem hiding this comment.
ruff yells at me without the # noqa
dreulavelle
commented
Mar 2, 2024
| # @make start | ||
| lint: | ||
| ruff check backend | ||
| pyright backend |
There was a problem hiding this comment.
I'm expecting the lint/test commands to change.. just tossing these here for now. feel free to make changes to the makefile as needed.
dreulavelle
commented
Mar 2, 2024
| @echo ------------------------------------------------------------------------- | ||
|
|
||
| install: | ||
| @python3 -m pip install -r requirements.txt --break-system-packages | ||
| @pip install -r requirements.txt --upgrade --break-system-packages |
There was a problem hiding this comment.
possibly switch to using poetry instead? would handle packages better than this :/
|
this ones ready for now |
AyushSehrawat
approved these changes
Mar 3, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.