Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Todos #124

Open
mlesnick opened this issue Jun 24, 2018 · 2 comments
Open

Documentation Todos #124

mlesnick opened this issue Jun 24, 2018 · 2 comments
Labels

Comments

@mlesnick
Copy link
Contributor

mlesnick commented Jun 24, 2018

The RIVET documentation has improved a lot recently, but still needs some work. A detailed list of todos is at the bottom of the about page in the documentation.

@mlesnick
Copy link
Contributor Author

mlesnick commented Feb 23, 2020

Major updates to the documentation are in the works to accompany improvements to RIVET handling of input data.

Also, here is one significant omission in documentation: In the case of descending coordiantes, the documentation does not explain the parameterization used by RIVET when printing barcodes to the console using the --barcodes flag. Changing one coordinate direction effectively makes the slope of the line negative, so that the rule described in the documentation doesn't apply. I expect that the rule which has been implemented is to unflip the flipped coordinate direction by multiplying this coordinate by -1, and then use the rule described in the documentation. But this should be checked.

@mlwright84
Copy link
Contributor

The documentation has been updated to describe the new file input formats and flags that Anway has implemented since 2019.

Here are two todos that used to be noted in about.rst:

  • In the discussion of the Persistence Diagram Window, some details about how the persistence diagram is drawn appear in the appendix of the arXiv paper, but not in the documentation. For example, the way we handle normalization when "fit to window" is selected is only discussed in the appendix. We suggest that all details be given in the documentation and removed from the paper.
  • The examples could use some polish. More examples are desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants