Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too easy to incorrectly use "points" datatype instead of "metric" #160

Open
mlesnick opened this issue Jan 22, 2021 · 0 comments
Open

Too easy to incorrectly use "points" datatype instead of "metric" #160

mlesnick opened this issue Jan 22, 2021 · 0 comments
Labels

Comments

@mlesnick
Copy link
Contributor

I have been using the new version of RIVET for some exploratory data analysis, and am general happy with the experience.

However, I've found that the design of the file input dialogue makes it too easy to incorrectly choose the default "points" instead of "metric" when working with a distance matrix without the --datatype metric flag included. I made this mistake a couple of times. It turned out that the results with "points" were actually kind of similar; it is not so obvious from the output that you have done the computation incorrectly, and that is a recipe for problems.

So I suggest that if a .csv file is given without the datatype file, the datatype selector defaults to "no selection" or something similar, and the user has to explicitly choose "points" or "metric" before they can press "compute."

I suppose this is also a potential problem on the command line, but there I'm less sure what the right solution is. Should we eliminate the default datatype altogether?

@mlesnick mlesnick added the task label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant