Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling / logging #73

Open
jerrypnz opened this issue Aug 27, 2018 · 0 comments
Open

Better error handling / logging #73

jerrypnz opened this issue Aug 27, 2018 · 0 comments

Comments

@jerrypnz
Copy link

jerrypnz commented Aug 27, 2018

There are a lot of places where exceptions are caught and logged using printStackTrace or System.err.println. It's not ideal for production systems where errors are generally written to log files instead of stderr.

Would be great if they can be replaced with an actual logger like slf4j, or maybe it should always bubble up exceptions to the caller and leave it to them to decide how exceptions should be handled.

If you think it's a good idea, we have a patch which replaces printStackTrace and System.err.println with slf4j Logger.error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant