Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fields nullability in subscriptions documentation #3194

Merged

Conversation

00dav00
Copy link
Contributor

@00dav00 00dav00 commented Oct 15, 2020

The documentation on subscriptions page show Room and Message as mandatory in the client side, but the ruby class show them as null: true. This change makes them not nullable in the ruby gql class to have consistency

type MessageWasPostedPayload {
  room: Room!
  message: Message!
}

@rmosolgo
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants