From 08e1f1b8d043709b9c704f6802271ed2461a1644 Mon Sep 17 00:00:00 2001
From: Valery Piashchynski <piashchynski.valery@gmail.com>
Date: Fri, 30 Aug 2024 13:03:03 +0200
Subject: [PATCH] chore: remove central pools shutdown policy

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
---
 .golangci.yml |  2 +-
 Makefile      |  4 ++--
 plugin.go     | 29 +----------------------------
 3 files changed, 4 insertions(+), 31 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 1ea1a0b..b3a0873 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -40,7 +40,7 @@ linters: # All available linters list: <https://golangci-lint.run/usage/linters/
     - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases
     - errorlint # find code that will cause problems with the error wrapping scheme introduced in Go 1.13
     - exhaustive # check exhaustiveness of enum switch statements
-    - exportloopref # checks for pointers to enclosing loop variables
+    - copyloopvar # checks for pointers to enclosing loop variables
     - gochecknoglobals # Checks that no globals are present in Go code
     - gochecknoinits # Checks that no init functions are present in Go code
     - gocognit # Computes and checks the cognitive complexity of functions
diff --git a/Makefile b/Makefile
index ce1f074..75a17a1 100644
--- a/Makefile
+++ b/Makefile
@@ -1,2 +1,2 @@
-testpkg:
-	go test -v -race -cover -tags=debug ./...
\ No newline at end of file
+test:
+	go test -v -race -cover -tags=race -tags=debug ./...
\ No newline at end of file
diff --git a/plugin.go b/plugin.go
index cae824b..5dd56ed 100644
--- a/plugin.go
+++ b/plugin.go
@@ -8,7 +8,6 @@ import (
 	"strconv"
 	"strings"
 	"sync"
-	"time"
 
 	"github.com/roadrunner-server/errors"
 	"go.uber.org/zap"
@@ -29,8 +28,6 @@ type Plugin struct {
 
 	log     *zap.Logger
 	factory pool.Factory
-
-	pools []Pool
 }
 
 // Init application provider.
@@ -84,8 +81,6 @@ func (p *Plugin) Init(cfg Configurer, log NamedLogger) error {
 
 	p.preparedEnvs = append(p.preparedEnvs, fmt.Sprintf("%s=%s", RrVersion, cfg.RRVersion()))
 
-	p.pools = make([]Pool, 0, 4)
-
 	p.factory, err = initFactory(p.log, p.cfg.Relay)
 	if err != nil {
 		return errors.E(op, err)
@@ -114,30 +109,10 @@ func (p *Plugin) Serve() chan error {
 }
 
 // Stop used to stop all allocated pools
-func (p *Plugin) Stop(ctx context.Context) error {
+func (p *Plugin) Stop(_ context.Context) error {
 	p.mu.Lock()
 	defer p.mu.Unlock()
 
-	wg := &sync.WaitGroup{}
-	wg.Add(len(p.pools))
-
-	// destroy all pools in parallel
-	for i := 0; i < len(p.pools); i++ {
-		go func(idx int) {
-			if p.pools[idx] == nil || p.pools[idx].(*staticPool.Pool) == nil {
-				wg.Done()
-				return
-			}
-			ctx2, cancel := context.WithTimeout(ctx, p.pools[idx].GetConfig().DestroyTimeout)
-			p.pools[idx].Destroy(ctx2)
-			cancel()
-			wg.Done()
-		}(i)
-	}
-
-	wg.Wait()
-	// just to be sure that all logs are synced
-	time.Sleep(time.Second)
 	return p.factory.Close()
 }
 
@@ -165,8 +140,6 @@ func (p *Plugin) NewPool(ctx context.Context, cfg *pool.Config, env map[string]s
 		return nil, err
 	}
 
-	p.pools = append(p.pools, pl)
-
 	return pl, nil
 }