Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Binary for Apple Silicon #139

Closed
thebitstick opened this issue Nov 24, 2020 · 14 comments
Closed

Universal Binary for Apple Silicon #139

thebitstick opened this issue Nov 24, 2020 · 14 comments

Comments

@thebitstick
Copy link

Seashore works great through Rosetta, but a native binary would be nice!

@robaho
Copy link
Owner

robaho commented Nov 24, 2020

Thank you for the input. It is actually a bit of work to port, and given that I don't have hardware to test on, and any donations haven't come close to even a down payment, it is doubtful.

If I am going to make an effort in this area, I will probably do a complete rewrite in a new commercial app.

@ThatGuySam
Copy link

@robaho Is this closed because you don't have a method to test it?

@robaho
Copy link
Owner

robaho commented Feb 9, 2021

Pretty much. It’s hard to accept a PR that I have no way of testing.

@ThatGuySam
Copy link

If you can provide a list of specific features to test along with some sample files, I can create a callout for testers to create a screen recorded review of the Universal Binary.

@thebitstick
Copy link
Author

I volunteer to test on my Mac mini M1.

@ThatGuySam
Copy link

@thebitstick That's awesome!!

@ThatGuySam
Copy link

I'm sure @robaho will have more specific things to try, but if you could post a screen recording of the following that would be a good start:

  • Show App's "Get Info"
  • Launch App
  • Pull up Activity Monitor with app listing visible
  • Save file
  • Load file

If you need a screen recording app you can simply have Quicktime record the screen by pressing: Command + Shift + 5

@robaho
Copy link
Owner

robaho commented Feb 10, 2021

There is no PR to support Apple silicon. I don't have the time to create and test one. It is more than just setting some complier flags - there is some C code and other memory manipulation operations that I assume need to be changed for direct compilation.

Since Seashore is released on the App Store, I cannot submit a partially working, or partially tested App. So there would need to be a full PR with complete testing and test reports of all operations. It is a lot of work IMO.

@robaho
Copy link
Owner

robaho commented Feb 10, 2021

As I mentioned, if I invest the time to support Apple silicon it will probably be on a completely new version written from the ground up in Swift. That being said, I will accept a PR to support Apple silicon, but the bar is very high for what needs to be included - since I can't break the App Store version.

@robaho
Copy link
Owner

robaho commented Feb 10, 2021

I am re-opening the issue so a PR can be created against it.

@robaho robaho reopened this Feb 10, 2021
@ThatGuySam
Copy link

Fair enough!

@mugsuk
Copy link

mugsuk commented Sep 28, 2021

@robaho, I couldn't find a way to contact you other than through issues, to thank you so much for what you have done for Seashore. I have been using it since it was first released, then resorted to Gimp when seashore died; I have not had to open Gimp again since you resurrected this, and I use it daily. This level of quality for open source software on the Mac is phenomenal. Thanks again

@robaho
Copy link
Owner

robaho commented Sep 29, 2021

Thanks for the kind words @mugsuk

@robaho
Copy link
Owner

robaho commented Jul 1, 2022

fixed in 3.01

@robaho robaho closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants