context in cron.Job.Run Is it possible?

[Breezess]

I want to pass in the context in cron.Job.Run, is there any way?

return cron.WithChain(func(job cron.Job) cron.Job {
	return cron.FuncJob(func() {
                // There is a way to write context 
                  job.Run()
                 // use context 
	})
})

[ex-tag]

@robfig

The AddFunc method should pass a context to the added function, as there might be websocket connections, or long-polling HTTP requests, that are open - and need to be cancelled when the task closes. Without this cancellation, these connections would remain open, and they would not be closed until the server was able to respond back, and therefore blocking additional connections that could be made. Please read https://go.dev/blog/context and https://pkg.go.dev/context for more information.

Example implementation

cron.New().AddFunc("", function (context c.Context) {

  request.Context(context)

})

Example source code change

func (c *Cron) AddFunc(spec string, cmd func(context c.Context)) error {
	return c.AddJob(spec, FuncJob(cmd))
}

[Slava02]

@robfig

Can you merge this pr?

#516

[tooptoop4]

robfig dipped out, dis abandonware ☠️

[flc1125]

Based on this project, I forked a project and kept the record of original historical submissions. At the same time, the 4.x version is under development, and if you are interested, you can join it together.
https://github.com/flc1125/go-cron

I added context.Context to this version, as well as error returns.

ex:

package main

import (
	"context"

	"github.com/flc1125/go-cron/v4"
	"github.com/flc1125/go-cron/v4/middleware/recovery"
)

func main() {
	c := cron.New()
	c.Use(recovery.New())

	c.AddFunc("* * * * * ?", func(ctx context.Context) error {
		panic("YOLO")
	})

	c.Start()
	defer c.Stop()
}

[flc1125]

V4.0.0 has been released, welcome to use it.👏🏻