-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
World files cannot load models via URI (to fuel.ignitionrobotics.org) #168
Comments
Hi @wolfgangschwab, |
With the released versions of gym-ignition I never tried to load world with models included as Fuel URIs, I would not be surprised if something would not work. However, thinking about how the world model is processed, it should be Spoiler alert: If you didn't notice, we're in the process of a big C++ refactoring #155, and in the gym-ignition/cpp/scenario/gazebo/include/scenario/gazebo/utils.h Lines 48 to 49 in a303413
Fuel support is one of many new features that are coming soon. The |
The major point was, that callback-functions were missing in GazeboWrapper::findAndLoadSdf . So I added
Additionally I had to write the callback-functions and add the ignition fuel-tools package. For world files this works. With robots I still have problems. But currently I'm looking more how laser-sensors (Lidar) can be used. As I understand currently Laser sensors are not implemented. Do you have plans to do so in the near future? |
@wolfgangschwab thanks a lot for the suggestion, I'll have a look!
I general, sensors are not yet supported by the framework. In the next months we have other features we need with more urgency, I doubt anyone would start looking into sensors integration in the next few months. If you're interested in contributing, I'd be happy to discuss in a new issue how to implement them. |
Thanks, I will open a new issue for the Lidar-Sensors. Regarding the fix for using URI with fuel: Just tell me, if you would like to get additional info or a Pull request. |
Go ahead with a PR, you can target directly
Perfect, thanks! |
I raised Pull Request #174 to solve this issue. |
Closed via #309 |
Using a world file that contains URIs to fuel.ignitionrobotics.org generates errors.
I added some code to my local copy of the repository to solve this issue. So, models are automatically loaded from the website. If you are interested in the solution, I can generate a Pull request with this.
The text was updated successfully, but these errors were encountered: