Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate models to use new gazebo_yarp_robotinteface plugin #215

Closed
traversaro opened this issue Dec 9, 2021 · 6 comments
Closed

Migrate models to use new gazebo_yarp_robotinteface plugin #215

traversaro opened this issue Dec 9, 2021 · 6 comments

Comments

@traversaro
Copy link
Member

No description provided.

@traversaro
Copy link
Member Author

After completing robotology/gazebo-yarp-plugins#615 and robotology/gazebo-yarp-plugins#616, I started looking into this. However, I just realized that we would need now to hardcode icubSim in all the wrapper configuration files, basically preventing any use case in which we have two different iCub models (with different port prefix) in the same simulation, see for example https://icub-tech-iit.github.io/documentation/icub_setup_multiple_robots/two_robots_simulation/ .

This is quite problematic as the two iCub use case is quite widespread in some subgroups of AMI (fyi @lrapetti).

@Nicogene @ste93 @randaz81 do you have any idea on how we can replicate a similar behavior with the new structure? Basically we would need that the port prefix used by the model (i.e. icubSim) can be optionally be specified programmatically, so that we can spawn multiple icub models without any port conflict.

@traversaro
Copy link
Member Author

traversaro commented Mar 22, 2022

We discussed with @randaz81 and we agreed that I will implement the possibility in YARP of using the ${portprefix} variable in the yarprobotinterface .xml file to refer to the portprefix=<> attribute of the robot element, that is already required and unused (see robotology/yarp#2492). This (associated with the appropriate option in gazebo_yarp_robotinterface to override the portprefix from SDF) will permit to have two iCubs simulated in the same Gazebo world without any YARP port name conflict.

@lrapetti
Copy link
Member

We discussed with @randaz81 and we agreed that I will implement the possibility in YARP of using the ${portprefix} variable in the yarprobotinterface .xml file to refer to the portprefix=<> attribute of the robot element, that is already required and unused (see robotology/yarp#2492).

This is nice @traversaro! Thanks for taking care of it, and let me know if you need any support, or help for testing it!

@traversaro
Copy link
Member Author

Fix for iCub 3 in #222 .

@traversaro
Copy link
Member Author

The last problems with this were fixed with the mentioned PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants