Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required metrics in README is missing a few values #354

Open
voidlily opened this issue Oct 31, 2024 · 1 comment
Open

Required metrics in README is missing a few values #354

voidlily opened this issue Oct 31, 2024 · 1 comment

Comments

@voidlily
Copy link

Describe the bug
In my cluster I'm having issues with the high cardinality of cAdvisor metrics and trying to make an allowlist of only the metrics krr needs. The readme mentioned these metrics

container_cpu_usage_seconds_total
container_memory_working_set_bytes

I noticed however that there were others missing like machine_memory_bytes and machine_cpu_cores that the cluster summary asks for and are otherwise missing.

For kube-state-metrics there's a few others I noticed but might have missed, because I haven't yet tried limiting kube-state-metrics because its cardinality was not as high as cAdvisor was.

kube_pod_container_resource_limits
kube_job_owner
kube_pod_container_status_last_terminated_reason

This might not even be all of them, I didn't search very deeply in the code yet.

Expected behavior
A list of all metrics that krr expects so I can make a thorough allowlist. Possibly tailored to which component of kube-prometheus-stack each comes from (cAdvisor, kubelet, kube-state-metrics, etc), though not strictly necessary.

@aantn
Copy link
Contributor

aantn commented Nov 3, 2024

Thanks, you're right! If you're open to contributing, we'd love to accept a PR improving the docs on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants