Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support modifying LocalizationTable entries #317

Open
Tracked by #30
hoontee opened this issue Jul 8, 2023 · 2 comments
Open
Tracked by #30

Support modifying LocalizationTable entries #317

hoontee opened this issue Jul 8, 2023 · 2 comments

Comments

@hoontee
Copy link

hoontee commented Jul 8, 2023

Similar to #316, LocalizationTable.Contents is encoded and should support edits using the same format as LocalizationTable.SetEntries.

This function is available in Rojo but it should be moved to rbx-dom.

Test file (RBXM / RBXMX): CSV.zip
@hoontee hoontee mentioned this issue Jul 8, 2023
Open
2 tasks
@Dekkonot
Copy link
Member

I don't see a path forward for this that isn't essentially us reimplementing an interface for CSV files. I'm interested in what your preferred API would look like.

@hoontee
Copy link
Author

hoontee commented Aug 30, 2023

Alternative implementation: change the type of Contents to be a writable table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dekkonot @hoontee