Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.WorldPivotData does not need a custom setter/getter and should instead alias to Model.WorldPivot #430

Open
Dekkonot opened this issue Jul 23, 2024 · 0 comments

Comments

@Dekkonot
Copy link
Member

As it says in the issue title, right now we have a custom setter/getter for Model.WorldPivotData in rbx_dom_lua that just sets Model.WorldPivot directly. This is correct behavior, but it's also unnecessary and we should instead alias WorldPivotData.

This is complicated somewhat because they're two different types (WorldPivotData is OptionalCFrame, WorldPivot is CFrame) but we can add a conversion between the two and then set an alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant