Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HumanoidDescription.EquippedEmotesDataInternal and EmotesDataInternal are non-deterministic #447

Open
Dekkonot opened this issue Sep 20, 2024 · 2 comments
Labels
type: bug Something isn't working upstream

Comments

@Dekkonot
Copy link
Member

Like the title says. The properties I listed above are non-deterministic when serialized by Roblox, so they aren't when they're serialized by us. This is not technically a bug with our code, since it's Roblox's fault, but it's still annoying.

Given that one of our goals is deterministic serialization, I think this is important. I'm not sure what we should do about this, if anything. This issue is mostly for a discussion on any solution.

@Dekkonot Dekkonot added type: bug Something isn't working upstream labels Sep 20, 2024
@kennethloeffler
Copy link
Member

kennethloeffler commented Sep 20, 2024

I've noticed something similar with properties like HumanoidDescription.BackAccessoryas well; the engine seems to reorder the entries when the property is set. Maybe there is some order they're respecting that we can reimplement? Seems like a lot of hassle though

@Dekkonot
Copy link
Member Author

I've forwarded this to someone at Roblox and they're looking into it. Here's a related bug report if you want to attach any other properties that you've noticed: https://devforum.roblox.com/t/3166009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

2 participants