Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand diff of Source modifications in initial sync diff viewer #700

Closed
JohnnyMorganz opened this issue Jun 19, 2023 · 4 comments
Closed
Assignees
Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@JohnnyMorganz
Copy link
Contributor

I'm liking the recent new feature to view a diff of changes before accepting the initial sync - it helps to confirm that everything is as expected.

Would it be possible to potential expand the view on Source changes for scripts? It is difficult to see what's changed in the following UI:

image

It would be nice to be able to expand this (potentially even into a text-diff viewer, not sure if that's possible), so that I can confirm that the change is correct

@boatbomber
Copy link
Member

This is something I definitely want to support. I originally made the diff view to fill a couple use cases, namely to prevent accidentally syncing the wrong place and overwriting work as well as being aware of Rojo's current sync status.
Future versions should definitely support more complex inspection like this.

@boatbomber
Copy link
Member

boatbomber commented Jul 1, 2023

I don't think there's enough room in this UI to display the information you want. It's designed to show property changes, which are generally only a handful of characters long. I think we can special case string properties like Source to have a popout button to view a full size diff window.

not sure if that's possible

Neil Fraser, the wonderful mind behind Google Docs, created and open sourced a diff-match-patch utility. It was then translated to Lua by Duncan Cross. I believe that I can adapt that for Luau (respecting the license, of course) and use that for really rich semantic diffs for Rojo users.

I call dibs on first crack at this issue!

@boatbomber
Copy link
Member

boatbomber commented Jul 1, 2023

Working prototype! Long way to go though.

image
image

@boatbomber boatbomber self-assigned this Jul 2, 2023
@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. labels Jul 2, 2023
@boatbomber
Copy link
Member

#748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

No branches or pull requests

2 participants