Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch visualizer doesn't display failed instance additions #842

Closed
kennethloeffler opened this issue Jan 30, 2024 · 0 comments · Fixed by #844
Closed

Patch visualizer doesn't display failed instance additions #842

kennethloeffler opened this issue Jan 30, 2024 · 0 comments · Fixed by #844
Assignees
Labels
scope: plugin Relevant to the Roblox Studio plugin type: bug Something happens that shouldn't happen

Comments

@kennethloeffler
Copy link
Member

kennethloeffler commented Jan 30, 2024

While reproducing the issue described in #841, I noticed some odd behavior from the patch visualizer. To reproduce, download the following project and follow the steps below: part-package.zip. This reproduces on Rojo 7.4.0.

  1. Run rojo serve on the provided project.
  2. Open a fresh baseplate in Roblox Studio and connect the Rojo plugin. With trace output enabled, you should see something like this after accepting the initial sync:
    image

PackageLink is not creatable. The trace output shows that the PackageLink addition is being added to the unapplied patch, and the status indicator correctly reports that 5 changes (4 properties on the part plus the failed PackageLink addition) failed to apply, but the expanded patch visualizer does not indicate the failure.

cc @boatbomber

@Dekkonot Dekkonot added type: bug Something happens that shouldn't happen scope: plugin Relevant to the Roblox Studio plugin labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: plugin Relevant to the Roblox Studio plugin type: bug Something happens that shouldn't happen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants