Bug Report: Timer stops when computer goes to sleep

[moltar]

Describe the bug

Timer stops working when computer goes to sleep.

To Reproduce

1. Start timer.
2. Close computer lid
3. Wait 2 minutes
4. Open lid and wait for computer to wake up
5. Observe timer had not subtracted 2 minutes, and it is currently stopped (not counting).

Expected behavior

Timer continues counting after re-opening of the computer.

Screenshots

N/A

Desktop (please complete the following information):

• OS: macOS Catalina
• Version: 10.15.4 (19E287)

Additional context

This feature is mostly important for break timers. When I am on a 15 minute break, the computer may fall asleep.

[roldanjr]

Describe the bug

Timer stops working when computer goes to sleep.

To Reproduce

1. Start timer.
2. Close computer lid
3. Wait 2 minutes
4. Open lid and wait for computer to wake up
5. Observe timer had not subtracted 2 minutes, and it is currently stopped (not counting).

Expected behavior

Timer continues counting after re-opening of the computer.

Screenshots

N/A

Desktop (please complete the following information):

• OS: macOS Catalina
• Version: 10.15.4 (19E287)

Additional context

This feature is mostly important for break timers. When I am on a 15 minute break, the computer may fall asleep.

I've also encountered that and I have no idea how to prevent Operating System to not fall asleep while timer still running.

Anyway thanks for informing me. I will try to fix that ASAP on my next release.

[moltar]

I think the solution would be not to store the remaining seconds, but rather store the start date, and then calculate the remaining time based on that.

[roldanjr]

I'm not that good enough to comprehend what do you mean by that. If possible can you provide some good example on how to do that?

[roldanjr]

I have tried the PowerSaveBlocker of Electron preventing the Operating System from entering sleep mode before but it didn't work on my Laptop.

[moltar]

I am not sure how the app works. But I am assuming there is a sort of thing:

let remainingSeconds = 100

setInterval(() => remainingSeconds = remainingSeconds - 1, 1000)

But instead, should be something like:

const timeStartDate = new Date()
const timerDurationMs = 15 * 60 * 1000
let remainingTime = 0

setInterval(() => {
  remainingTime = timerDurationMs - (new Date().getTime() - timeStartDate.getTime())
}), 1000)

That way, the hard date is saved, and it can always be referenced again.

But maybe this is already how it works, I am not sure.

[moltar]

Then probably want an event like resume when it comes back from sleep to fire of the timers in the UI again:

https://www.electronjs.org/docs/api/power-monitor

[roldanjr]

I am not sure how the app works. But I am assuming there is a sort of thing:

let remainingSeconds = 100

setInterval(() => remainingSeconds = remainingSeconds - 1, 1000)

But instead, should be something like:

const timeStartDate = new Date()
const timerDurationMs = 15 * 60 * 1000
let remainingTime = 0

setInterval(() => {
  remainingTime = timerDurationMs - (new Date().getTime() - timeStartDate.getTime())
}), 1000)

That way, the hard date is saved, and it can always be referenced again.

But maybe this is already how it works, I am not sure.

Does it prevent the Operating System from asleep?

[roldanjr]

Then probably want an event like resume when it comes back from sleep to fire of the timers in the UI again:

https://www.electronjs.org/docs/api/power-monitor

I've also tried it before and it didn't work. I will try it again combining powerMonitor and PowerSaveBlocker with the latest Electron release.

[moltar]

Does it prevent the Operating System from asleep?

Not, but it will re-start from the right time if it wakes up at least.

Otherwise the time is frozen at the time when the system went to sleep.

[roldanjr]

I'm working with the new features of the app right now and will try to fix some bugs including the issue you've posted. I really appreciate your suggestion and will try it if my solutions didn't fix the issue at least.

[roldanjr]

Hi @moltar . I just released new version of the app.

Please visit v2.10.0-beta Release Note.
Also, let me know if the bug you've encountered fixed by this latest version of the app. Have a great day!

[moltar]

Ok, thanks. Upgraded, will try next week.

[moltar]

Got the following immediately after launching the upgraded version:

And I can't quit the app now.

[moltar]

The window is squished:

[roldanjr]

@moltar just go to Settings and just press Restore Default.

It might happened due to old settings are not compatible with the new features.

Please let me know the results.

[moltar]

just go to Settings and just press Restore Default.

That did fix it, thanks.

[moltar]

I think this is still an issue.

I just had a 5 minute timer go off. Full screen.
I closed the lid.
10 minutes passed
I opened the lid, and the timer was still at 4 minutes.

[roldanjr]

I'm sorry @moltar but I think it is not an issue.

Just don't closed the lid or manually sleep the computer because the app doesn't have the full control to prevent you from making your computer off / sleep. The only concern here is that the app will prevent your computer from automatically sleeping while your computer is on idle especially when full-screen persisted and preventing you from working.

If you really want to take that break. I suggest just don't close the lid. Just wait for the break to finished.