Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Numbers #557

Open
Quiddlee opened this issue Sep 26, 2024 · 0 comments Β· May be fixed by #585
Open

FSD: Widget Numbers #557

Quiddlee opened this issue Sep 26, 2024 · 0 comments Β· May be fixed by #585

Comments

@Quiddlee
Copy link
Collaborator

Quiddlee commented Sep 26, 2024

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/numbers

βœ… Definition of Done (DoD):

not-found.modules.scss

  1. Refactor numbers.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

not-found.tsx

  1. replace div's with HTML5 tags
  2. rename image constant to something more meaningful
  3. add descriptive alt attribute
  4. replace InfoCellDivider with css
  5. remove redundant div's if possible

info-cell.tsx

  1. encapsulate component in separate file inside the ui folder
  2. replace interface with type
  3. replace div's with HTML5 tags

numbers.test.tsx

  1. move test to ui folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Peer review
Development

Successfully merging a pull request may close this issue.

1 participant