Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base url not being applied to all links #209

Closed
Tracked by #200
MSevey opened this issue Aug 10, 2023 · 4 comments
Closed
Tracked by #200

Base url not being applied to all links #209

MSevey opened this issue Aug 10, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@MSevey
Copy link
Contributor

MSevey commented Aug 10, 2023

Version of Git SHA

main

System OS

github runners

Installed tools

No response

Others

No response

Steps to reproduce it

create a PR and try and navigate the pr preview

Expected result

the pr-preview/pr-## should stay in the url as you navigate the site to ensure that you are seeing the actual preview and not the main deployed site.

Actual result

the base url is only applied to the home page.

Relevant log output

No response

Notes

No response

@MSevey MSevey added the bug Something isn't working label Aug 10, 2023
@MSevey
Copy link
Contributor Author

MSevey commented Aug 10, 2023

This: https://vitepress.dev/reference/site-config#base

Seems to imply we just need to define it once, but it doesn't seem to be sticking.

Maybe it's a bug with vitepress?

Locally when I try clicking around the site, I start getting this

http://localhost:5173/testing/testing/testing/reference/testing/tutorials/testing/reference/testing/testing/testing/testing/testing/

@jcstein
Copy link
Member

jcstein commented Aug 10, 2023

it looks like it works on #210 preview https://rollkit.dev/pr-preview/pr-210/tutorials/gm-world-frontend

@jcstein
Copy link
Member

jcstein commented Aug 10, 2023

seems to be working in #204 as well now 😄

@jcstein
Copy link
Member

jcstein commented Aug 10, 2023

testing 2023-08-10 at 13 15 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants