-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to make rollup-plugin-typescript2 the "official" typescript plugin #541
Comments
They each have their own merits and their own problems. To state that one is better than the other is purely subjective. I typically find the the ts2 plugin is a dumpster fire of quirks and workarounds for larger projects, which is most of what I work on for my regular job. I don't have the same issues with the official plugin, thanks to the excellent work of @NotWoods. In my subjective opinion, the plugin here is superior. As for combining forces, we'd absolutely welcome contributions here from the ts2 plugin author, without question and with grace. We'd welcome your contributions to it as well.
NPM downloads are not an indicator of quality. They're usually an indicator of legacy. ts2 was created because rollup-plugin-typescript fell into neglect and disrepair. The scoped, official plugin came into being last year after many users had abandoned the old plugin. The nuance behind stats is important, ignore them at peril. That said, the suggestion that we scrap the plugin here and wholesale replace it is dead in the water. Closing for now, but please feel free to discuss further. (For those who do, be careful not to get personal in criticism) |
I'll add that I do also look at implementations used by other plugins and emulate parts that are important. |
I actually found In the meantime a lot of the issues I encountered with |
Hi @benmccann, I'm curious as to what bug you have encountered with |
It's been too long at this point. I don't remember |
I've recently encountered some really weird bugs in |
I appreciate all the work that's gone into
@rollup/plugin-typescript
. However, the fragmentation in the Rollup plugin ecosystem has made it very hard for me to get started as a user. I tried three different Rollup plugins (@plugins/typescript
,rollup-plugin-ts
, androllup-plugin-typescript
) before finally finding one that I could get working.rollup-plugin-typescript2
is the most trouble free in my experience.I'm guessing others have found that to be true too based off the usage stats:
@rollup/plugin-typescript
- 53k weekly downloadrollup-plugin-typescript2
- 260k weekly downloadsWhy not combine forces? Replace
@rollup/plugin-typescript
withrollup-plugin-typescript2
and all contribute to a single Rollup TypeScript plugin instead of splitting effortsThe text was updated successfully, but these errors were encountered: