Typescript 1.8.x

[stefanullinger]

Hi,

I would like to use your plugin with Typescript 1.8.x, so I tried

import typescript from 'rollup-plugin-typescript';
import * as ts from 'typescript';

export default {
    ...
    plugins: [
        typescript( {
            target: ts.ScriptTarget.ES6,
            typescript: ts
        } )
    ]
}

Unfortunately, there is a change in the API that is not compatible with your current code, as the host is getting passed as the third parameter instead of the fourth.

What would be the best way to fix this?!
I can submit a PR, if you like... but wanted to discuss the best way before.

Kind regards,
Stefan

[Victorystick]

I'm not sure. I suppose we could check the TS version and act differently for each API. PRs are always welcome.

[RReverser]

Oh, so it's not my misconfiguration.

@stefanullinger care to send a PR?

I tried to patch code in node_modules locally to var result = typescript.nodeModuleNameResolver(importee, importer, {}, resolveHost); and that fixed the issue.

[stefanullinger]

Yes, I can create the PR in the next couple of hours.

[RReverser]

Another possibly related (1.8 changes) issue: __awaiter implementation differs in https://github.com/rollup/rollup-plugin-typescript/blob/master/src/typescript-helpers.ts#L22 and TS-generated code.

See https://github.com/tifosiblack/typescript-helpers/issues/2#issuecomment-192992043 for details.

[Victorystick]

Released as 0.6.0.