Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin reading from chunks instead of assets #16

Open
mmmoussa opened this issue Dec 11, 2017 · 0 comments
Open

Plugin reading from chunks instead of assets #16

mmmoussa opened this issue Dec 11, 2017 · 0 comments

Comments

@mmmoussa
Copy link

This plugin uses the emit event of the compiler. According to the webpack docs, at this stage "the Compiler begins with emitting the generated assets. Here plugins have the last chance to add assets to the c.assets array." At this point in the webpack process I don't think it is correct for WebpackRtlPlugin to be using and updating the compilation chunks for operations. It should instead be using the compilation assets.

In one of my use cases for this plugin, I am using AddAssetHtmlPlugin to add some additional css files. AddAssetHtmlPlugin is being executed before WebpackRtlPlugin and is only adding assets to compilation.assets and not compilations.chunks, resulting in WebpackRtlPlugin not building the rtl version of these assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant