Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

☂️ Weekly goals - week 43 #1717

Closed
ematipico opened this issue Oct 26, 2021 · 1 comment
Closed

☂️ Weekly goals - week 43 #1717

ematipico opened this issue Oct 26, 2021 · 1 comment
Labels
umbrella Issue to track a collection of other issues

Comments

@ematipico
Copy link
Contributor

ematipico commented Oct 26, 2021

Last week the team met to define the architecture of our parser, so we didn't actually worked to anything other than discussing the future developments

High Level Objectives / Questions we're trying to answer

  • experiment with ungrammar and create a better ASTi (AST interface - or AST APIs) facade;
  • add Trivia to the current parser;

Projects / Tasks

  • new code generation using ungrammar, try to not break too much the existing generated nodes. This should result in 0 or few breaking changes;
  • make sure that ungrammar fits to represent the AST that we want to try to represent. Ideally we'd want to use what we had in the TypeScript version;
  • implement the Trivia concept to our green nodes;
  • make order to the licenses of the forks our current repository contains;

Risks

  • adding Trivia might cause too many breaking changes to the current parser logic;
  • we might not be able to maintain all the existing AST APIs we have in rslint_parser;
  • ungrammar might not be able to give us all the features we need to represent JavaScript grammar;
  • add new features to ungrammar in order to support our AST APIs;
@ematipico ematipico added umbrella Issue to track a collection of other issues weekly goals labels Oct 26, 2021
@ematipico ematipico changed the title ☂️ Weekly goales - week 43 ☂️ Weekly goals - week 43 Oct 26, 2021
@ematipico ematipico pinned this issue Oct 27, 2021
@MichaReiser
Copy link
Contributor

  • new code generation using ungrammar, try to not break too much the existing generated nodes. This should result in 0 or few breaking changes;
  • make sure that ungrammar fits to represent the AST that we want to try to represent. Ideally we'd want to use what we had in the TypeScript version;

PR ready (#1715), merge pending. Some follow up work needed but can be done as part of #1725

  • implement the Trivia concept to our green nodes;

Work started but is still in progress. We'll carry this over to this week. #1720

  • make order to the licenses of the forks our current repository contains;

Not yet started. Carry over to this week.

@MichaReiser MichaReiser unpinned this issue Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
umbrella Issue to track a collection of other issues
Projects
None yet
Development

No branches or pull requests

2 participants