Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Gracefully remove TS parsing from JS parsing #1835

Closed
ematipico opened this issue Nov 30, 2021 · 1 comment
Closed

📎 Gracefully remove TS parsing from JS parsing #1835

ematipico opened this issue Nov 30, 2021 · 1 comment
Assignees
@ematipico
Labels
task A task, an action that needs to be performed

Comments

@ematipico
Copy link
Contributor

Description

Myself and @MichaReiser had a chat this afternoon and we agreed that, for now, we should comment/remove all the TS parsing that we have inside a normal JS parsing until we consolidate the a way to parse super languages in a good way.

For example here https://github.com/rome/tools/blob/main/crates/rslint_parser/src/syntax/stmt.rs#L180-L187 we would like to commented it out and avoid the parsing of TS, as it's not needed and it would not create issue.
@ematipico ematipico added the task A task, an action that needs to be performed label Nov 30, 2021
@ematipico ematipico mentioned this issue Nov 30, 2021
Closed
47 tasks
@ematipico ematipico self-assigned this Nov 30, 2021
@MichaReiser
Copy link
Contributor

I think we can keep the TS parsing in place as it is for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ematipico ematipico

Labels
task A task, an action that needs to be performed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ematipico @MichaReiser