Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Confusing error when running rome check with a directory #3329

Closed
sebmck opened this issue Oct 4, 2022 · 1 comment · Fixed by #3332
Closed

🐛 Confusing error when running rome check with a directory #3329

sebmck opened this issue Oct 4, 2022 · 1 comment · Fixed by #3332
Assignees
Labels
A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@sebmck
Copy link
Contributor

sebmck commented Oct 4, 2022

When I run rome check . I expected it to use the current directory and only lint valid files. However what happens is that it ends up erroring on the first file that we don't support. eg. I get the output:

./infra/terraform/.terraform/providers/registry.terraform.io/go-gandi/gandi/2.0.1/darwin_arm64 internalError/fs

  ✖ unhandled file type


Checked 0 files in 13ms

This isn't very helpful and it would be nice if when exploding a directory pattern on the CLI we filter it to supported files only.

I labeled this as a bug as this feels like some extraordinarily unexpected behaviour.

@sebmck sebmck added the S-To triage Status: user report of a possible bug that needs to be triaged label Oct 4, 2022
@leops
Copy link
Contributor

leops commented Oct 5, 2022

This is one really poorly worded diagnostic that I need to rewrite, it generally gets emitted when the filesystem traversal finds a symbolic link as we currently ignore them because they could lead to an infinite traversal loop. I'm not sure why it would cause the traversal to immediately abort and exit though, but I'll downgrade it from an error to a warning since it's only an indication to the user that the traversal may have missed some files.

@leops leops added S-Bug: confirmed Status: report has been confirmed as a valid bug A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Oct 5, 2022
@leops leops self-assigned this Oct 5, 2022
@ematipico ematipico added this to the 10.0.0 milestone Oct 5, 2022
@leops leops moved this to Done in Rome 2022 Oct 5, 2022
@ematipico ematipico removed this from the 10.0.0 milestone Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants