Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Rome misplaces closing braces in JSX props in some cases, compared to prettier #3499

Closed
1 task done
nstepien opened this issue Oct 26, 2022 · 0 comments · Fixed by #3505
Closed
1 task done

🐛 Rome misplaces closing braces in JSX props in some cases, compared to prettier #3499

nstepien opened this issue Oct 26, 2022 · 0 comments · Fixed by #3505
Assignees
@MichaReiser
Labels
A-Formatter Area: formatter S-Bug: confirmed Status: report has been confirmed as a valid bug
Milestone
10.0.0

Comments

@nstepien
Copy link
Contributor

Environment information

OS: win11, 64bit
installation method: npm i -D [email protected]

What happened?

  1. Open this playground
  2. Notice that Rome does not align the closing brace with the beginning of the prop in multiline props

Expected result

Prettier compatibility

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@nstepien nstepien added the S-To triage Status: user report of a possible bug that needs to be triaged label Oct 26, 2022
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug S-To triage Status: user report of a possible bug that needs to be triaged A-Formatter Area: formatter and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Oct 26, 2022
@MichaReiser MichaReiser self-assigned this Oct 26, 2022
@MichaReiser MichaReiser added this to the 10.0.0 milestone Oct 26, 2022
@MichaReiser MichaReiser linked a pull request Oct 26, 2022 that will close this issue
fix(rome_js_formatter): Arrow with JSX Body #3505
Merged
@MichaReiser MichaReiser moved this to Done in Rome 2022 Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaReiser MichaReiser

Labels
A-Formatter Area: formatter S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Rome 2022
Status: Done
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

fix(rome_js_formatter): Arrow with JSX Body rome/tools
2 participants
@nstepien @MichaReiser