This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_cli): correctly account for diff diagnostics in the printed diagnostics count #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
approved these changes
Nov 8, 2022
|
Have you tried using the new flags with the CLI by eg. calling it in the webpack or prettier project? |
I ran it locally on the repos being used for benchmarking just to be sure, it works as expected |
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 9, 2022
* upstream/main: fix(rome_js_analyze): Verify method name of React API calls (rome#3619) benchmark: Add pprettier and dprint to benchmark (rome#3597) feat(vscode): display the version of the language server in the status bar (rome#3616) fix(rome_cli): correctly account for diff diagnostics in the printed diagnostics count (rome#3595) fix(rome_cli): Respect formatter/linter `enabled` from configuration (rome#3591) Remove dead styles [website] Add scroll-padding-top
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3593
This PR adds checks against the
printed_diagnosticscounter in the console thread for diff diagnostics and general errors. This ensures the CLI never prints more diagnostics than the allowed maximum. I've also extended the--max-diagnosticsargument from thecheckcommand to theciandformatcommands, albeit with a different default value.Test Plan
I've added new tests for this in the CLI test suite but couldn't use the snapshot testing utility since the CLI runs multithreaded, and as a result the order of diagnostics printed in multiple files (for instance in many files formatted in parallel) is not deterministic and changes from one test run to another.