Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 noArrayIndexKey ignores valid cases #3670

Closed
1 task done
nstepien opened this issue Nov 11, 2022 · 1 comment · Fixed by #3681
Closed
1 task done

🐛 noArrayIndexKey ignores valid cases #3670

nstepien opened this issue Nov 11, 2022 · 1 comment · Fixed by #3681
Labels
A-Linter Area: linter L-JSX Language: JSX S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@nstepien
Copy link
Contributor

Environment information

Rome playground

What happened?

  1. Open this playground
  2. check diagnostics, notice that the returned parts are ignored.

Expected result

return should not break the rule.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@nstepien nstepien added the S-To triage Status: user report of a possible bug that needs to be triaged label Nov 11, 2022
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter L-JSX Language: JSX and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Nov 11, 2022
@MichaReiser
Copy link
Contributor

Uh, that's odd.

Issue: noArrayIndexKey ignores expressions in return statements (and potentially other statements?)

@lucasweng lucasweng mentioned this issue Nov 11, 2022
Merged
@ematipico ematipico added this to the 11.0.0 milestone Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Linter Area: linter L-JSX Language: JSX S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rome_js_analyze): false negatives of noArrayIndexKey
3 participants
@nstepien @ematipico @MichaReiser