Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 noConstAssign incorrectly flags argument assignment #3728

Closed
1 task done
nstepien opened this issue Nov 14, 2022 · 0 comments · Fixed by #3747
Closed
1 task done

🐛 noConstAssign incorrectly flags argument assignment #3728

nstepien opened this issue Nov 14, 2022 · 0 comments · Fixed by #3747
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@nstepien
Copy link
Contributor

nstepien commented Nov 14, 2022 •
edited
Loading

Environment information

Rome playground

What happened?

  1. Open playground
  2. Notice that the example with let passes, while the example with const has a diagnostic issue

Expected result

No diagnostic issue with argument assignment.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@nstepien nstepien added the S-To triage Status: user report of a possible bug that needs to be triaged label Nov 14, 2022
@ematipico ematipico added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Nov 14, 2022
@ematipico ematipico added this to the 11.0.0 milestone Nov 14, 2022
@mzbac mzbac mentioned this issue Nov 15, 2022
Merged
@ematipico ematipico moved this to Todo in Rome 2022 Nov 16, 2022
@MichaReiser MichaReiser linked a pull request Nov 17, 2022 that will close this issue
fix(semantic_analyzers): fix the false positive for noConstAssign #3747
Merged
Repository owner moved this from Todo to Done in Rome 2022 Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(semantic_analyzers): fix the false positive for noConstAssign
2 participants
@nstepien @ematipico