Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in benchmark_material with clang #96

Closed
romeric opened this issue Jun 1, 2020 · 1 comment
Closed

Regression in benchmark_material with clang #96

romeric opened this issue Jun 1, 2020 · 1 comment
Labels
performance

Comments

@romeric
Copy link
Owner

romeric commented Jun 1, 2020

There is a slight regression while compiling benchmark_material with apple clang on macOS. seems to be related to changes permutation. The regression was introduced with this commit apparently 97179bb. GCC is unaffected.

Nothing seems suspicious but requires further testing and verifications.
@romeric
Copy link
Owner Author

romeric commented Jun 1, 2020

The issue was that generic version of permutation was being used due to a bug in the return type of tensor permutation that made it never get activated. Fix now [aace93e
]

@romeric romeric closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romeric