Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build on node 10.7.0 #86

Closed
romgrk opened this issue Dec 18, 2018 · 2 comments
Closed

Unable to build on node 10.7.0 #86

romgrk opened this issue Dec 18, 2018 · 2 comments

Comments

@romgrk
Copy link
Owner

romgrk commented Dec 18, 2018

Probably a Nan issue.

$ npm install node-gtk
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)

> [email protected] install /Users/me/node_modules/node-gtk
> if [ "$(uname)" = "Darwin" ] && [ "$(which brew)" != "" ]; then export PKG_CONFIG_PATH=$(brew --prefix libffi)/lib/pkgconfig; fi; node-pre-gyp install --fallback-to-build

...
  CXX(target) Release/obj.target/node_gtk/src/boxed.o
In file included from ../src/boxed.cc:5:
In file included from ../src/boxed.h:4:
../../nan/nan.h:1081:96: error: too many arguments to function call, expected at most 4, have 5
        length_ = string->WriteUtf8(v8::Isolate::GetCurrent(), str_, static_cast<int>(len), 0, flags);
                  ~~~~~~~~~~~~~~~~~                                                            ^~~~~
/Users/me/.node-gyp/10.7.0/include/node/v8.h:2622:3: note: 'WriteUtf8' declared here
  int WriteUtf8(char* buffer,
  ^
1 error generated.
make: *** [Release/obj.target/node_gtk/src/boxed.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
...
@romgrk romgrk mentioned this issue Dec 18, 2018
@romgrk
Copy link
Owner Author

romgrk commented Dec 18, 2018

Update when nodejs/nan#833 is published.

@romgrk
Copy link
Owner Author

romgrk commented Jan 14, 2019

Pinned to [email protected] in 6a8da42 and published patch version to npm.

@romgrk romgrk closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant