0.10-RC1: Incorrect example for TypesAnnotated.with()

[davidburstrom]

In the example in the readme it states that

Set<Class<?>> annotated = 
  reflections.get(TypesAnnotated.with(SomeAnnotation.class));

In 0.10-RC1, it results in a Set<String>, as with() is backed by default QueryFunction<Store, String> with(Class<?>... keys) { return of(keys); }. Not only that, the collection is empty contrary to what was returned in 0.9.12.

[ronmamo]

thanks @davidburstrom , I've fixed the readme example.
as for the empty result - shouldn't happen unless the scanner was configured, as tested in ReflectionsQueryTest. can you check the configuration or share how Reflections was instantiated?
(ref pr)

[davidburstrom]

I'm a little surprised though, I'd have thought the README actually was more correct than the code.

What I used in 0.9.12 was

  public static Set<Class<?>> getValidStuff() {
    return new Reflections("valid").getTypesAnnotatedWith(Stuff.class);
  }

which worked great.

In 0.10-RC1, I had to adapt the return type to

  public static Collection<Class<?>> getValidStuff() {
    return new Reflections("valid").getTypesAnnotatedWith(Stuff.class);
  }

which stopped returning results.

Further changing of that into

  public static Set<String> getValidStuff() {
    return new Reflections("valid").get(TypesAnnotated.with(Stuff.class));
  }

brought me even further from the target, and didn't return anything either.

[ronmamo]

will change the results from Collection back to Set.

empty result - suspected changes are in ConfigurationBuilder or FilterBuilder, can you check the differences in the effective reflections.getConfiguration()?

preferably use the explicit constructor to avoid ambiguity (will improve javadoc/readme), such as

new Reflections(new ConfigurationBuilder().addUrls(ClasspathHelper.forPackage("valid")))
// or
new Reflections(new ConfigurationBuilder()
  .addUrls(ClasspathHelper.forPackage("valid")) 
  .setInputFilter(new FilterBuilder().includePattern(".*"))) // <-- optionally

either of the above will provide workable input, thanks for the coop!

[davidburstrom]

I personally have nothing against using Collection over Set in this case, but I suppose it does clarify that there will be no duplicates.

With 0.9.12 and

new Reflections("valid").getTypesAnnotatedWith(OptionsInterface.class);

the configuration looks like

and with 0.10-RC1 and

    final ConfigurationBuilder configurationBuilder =
    new ConfigurationBuilder().addUrls(ClasspathHelper.forPackage("valid"));
    configurationBuilder.setInputsFilter(new FilterBuilder().includePattern(".*"));
    final Reflections reflections = new Reflections(configurationBuilder);

the configuration looks like

The URLs are identical and I've confirmed that they contain the expected classes.

I've yet to find a spec that produces any output.

[ronmamo]

thanks @davidburstrom for your valuable feedback and time! these will be addressed for the next release.

[davidburstrom]

Trying out RC2, there are no changes required to use the Reflections API, but still, when querying for all types annotated with X, there are zero results where there used to be non-zero with 0.9.12.

[ronmamo]

thanks @davidburstrom , but I couldn't find a way to reproduce it. it might be some javassist issue (downgrade can provide more input). you can send me the jar on email and i'll take a closer look.

[davidburstrom]

I'll try and reproduce it in a self-enclosed project, hang on.

[davidburstrom]

repro-337.zip

There you go, fails on my machine at least. Just run gradle build. I didn't provide a Gradle wrapper script.

[ronmamo]

ok got it. this is now marked as a known issue and will be fixed on next release, looks like it's going to be earlier than I thought...
as a workaround for 0.10, mark your annotation with @Retention(RUNTIME)

[davidburstrom]

Great, thanks!

[ronmamo]

fixed in 0.10.1

[davidburstrom]

I can confirm the fix works as intended in 0.10.1 :)