Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daops consolidate - need to check why return types are different #81

Open
agstephens opened this issue Nov 10, 2021 · 0 comments
Open

daops consolidate - need to check why return types are different #81

agstephens opened this issue Nov 10, 2021 · 0 comments
Assignees
@agstephens @cehbrecht

Comments

@agstephens
Copy link
Collaborator

  • daops version: 0.7.0
  • Python version: all
  • Operating System: all

Description

The consolidate function appears to return different object types in this block:

https://github.com/roocs/daops/blob/master/daops/utils/consolidate.py#L151-L168

We think this is wrong - but it might affect how daops and rook interact with the function - need to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agstephens agstephens

@cehbrecht cehbrecht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agstephens @cehbrecht