Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a destroy() method? #37

Open
justincy opened this issue Oct 12, 2016 · 1 comment
Open

Add a destroy() method? #37

justincy opened this issue Oct 12, 2016 · 1 comment

Comments

@justincy
Copy link
Member

There are two general usecases:

  1. Inject genscrape and listen for all events (AJAX trees could fire multiple events as the user browses)
  2. Inject genscrape, wait for one event, then tear down

genscrape supports usecase (1) right now but doesn't support (2).

Should we add a configuration option that only allows one event to be fired or should we add a destroy() method that apps are expected to call when they want usecase (2)? Perhaps both.

@justincy
Copy link
Member Author

This issue is irrelevant if we commit to #75 because that kills usecase 1 from above and leads to usage where scrapers are expected to clean up when necessary after running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant