Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recs for obsolete_pkg_deps #107

Closed
maelle opened this issue Nov 18, 2021 · 3 comments
Closed

Add recs for obsolete_pkg_deps #107

maelle opened this issue Nov 18, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@maelle
Copy link
Contributor

maelle commented Nov 18, 2021

In https://github.com/ropensci-review-tools/pkgcheck/pull/69/files for each obsolete dep there was the name of the alternative. Or maybe there could be a link to the related dev guide section https://devguide.ropensci.org/building.html#recommended-scaffolding
@mpadge
Copy link
Member

mpadge commented Nov 18, 2021

Good idea, and great opportunity to develop a new print method. One thing I've been ignoring until now is the ordering of print methods, which this will be be a perfect opportunity to address. Thanks!

@mpadge mpadge added the enhancement New feature or request label Nov 18, 2021
@mpadge
Copy link
Member

mpadge commented Mar 21, 2022

@maelle This has now been addressed through functionality demonstrated at #44 (comment), right? Happy to close?

@maelle
Copy link
Contributor Author

maelle commented Mar 22, 2022

Yes!

@maelle maelle closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpadge @maelle