Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessing GHA workflows more precisely? #136

Open
maelle opened this issue Mar 8, 2022 · 9 comments
Open

Assessing GHA workflows more precisely? #136

maelle opened this issue Mar 8, 2022 · 9 comments

Comments

@maelle
Copy link
Contributor

maelle commented Mar 8, 2022

E.g. could pkgcheck detect if v2 of r-lib/actions are used?

@mpadge
Copy link
Member

mpadge commented Mar 8, 2022

Yes, easily. That's likely a good check to implement here - shall i have a go in the next coupla weeks, or do you want to try that? Or @assignUser if you'd be interested in attempting this? Your insight into our general way of inserting new checks would likely be really useful so please let us know if you'd be interested?

@assignUser
Copy link
Collaborator

So:

  • detect use of r-lib/actions
  • check for v2
  • raise note in CI section or error?

@maelle
Copy link
Contributor Author

maelle commented Mar 8, 2022

I'd say error?

@mpadge
Copy link
Member

mpadge commented Mar 8, 2022

Slightly more clearly:

  • detect presence of a pkgcheck file in .github/workflows
  • check for v2 of the main actions
  • Follow procedure described in vignette to write a check function, and to implement an output function with a condition !checks$checks$uses_actions_v2. The package should take care of the rest.

But only if you (@assignUser) want to do this - no worries if not i'll be happy to implement. Just let us know please.

@assignUser
Copy link
Collaborator

I am interested in doing this but I won't have time this week, if that's ok?

@mpadge
Copy link
Member

mpadge commented Mar 9, 2022

No worries - there's no rush at all. Whenever you can find time will be great. Thanks!

@maelle
Copy link
Contributor Author

maelle commented Mar 10, 2022

detect presence of a pkgcheck file in .github/workflows

What do you mean by that file?

@mpadge
Copy link
Member

mpadge commented Mar 10, 2022

pkgcheck::use_github_action_pkgcheck() creates a GHA workflow file

@maelle
Copy link
Contributor Author

maelle commented Mar 10, 2022

Oh, I was confused, I misread your earlier comment, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants