Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlm_gaussianfield #19

Closed
marcosci opened this issue Mar 1, 2018 · 0 comments
Closed

nlm_gaussianfield #19

marcosci opened this issue Mar 1, 2018 · 0 comments
Assignees

Comments

@marcosci
Copy link
Collaborator

marcosci commented Mar 1, 2018

ropensci/software-review#188 (comment):

See above issues with setting the random seed in nlm_fBm

Setting the mean value of the field doesn't work because of the line pred_raster <- pred_raster - raster::cellStats(pred_raster, "min"). Is there a purpose for this line of code? Removing this produces Gaussian random field surfaces with the given mean.

Add lower = 0 to the checks for resolution, mag_var and nug

Some additions to the documentation could improve the usability of this function. I would recommend further explanation of what each of the variance parameters do, in a way that the implications for the generated surface can be interpreted. My understanding of these are that:

mag_var sets the variation of the broad landscape
nug sets the variation within the scale of autocorr_range: low nug values will produce a highly spatially autocorrelated surface and high nug values a rougher surface.
Missing a reference, which would be useful for users to get a better understanding of how this function works.

@marcosci marcosci self-assigned this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant