Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlm_randomcluster -> nlm_neigh #24

Closed
marcosci opened this issue Mar 1, 2018 · 1 comment
Closed

nlm_randomcluster -> nlm_neigh #24

marcosci opened this issue Mar 1, 2018 · 1 comment
Assignees
@marcosci

Comments

@marcosci
Copy link
Collaborator

marcosci commented Mar 1, 2018 •
edited
Loading

ropensci/software-review#188 (comment):

The neighbourhood input is an integer here, whereas it was method names in nlm_neigh. It would be helpful to unify this (and the spelling of neighbourhood - one US, one British English). My preference would be the numbers, because I always forget the names and it's less to type!
@marcosci marcosci self-assigned this Mar 1, 2018
@z3tt
Copy link
Contributor

z3tt commented Mar 1, 2018

I would suggest an input called "neigh" or smt similar instead of having two version for both types of spelling.

@marcosci marcosci closed this as completed Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcosci marcosci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@z3tt @marcosci