Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect more examples of reviews for editors #363

Closed
maelle opened this issue Nov 26, 2021 · 2 comments · Fixed by #365
Closed

Collect more examples of reviews for editors #363

maelle opened this issue Nov 26, 2021 · 2 comments · Fixed by #365
Milestone

Comments

@maelle
Copy link
Member

maelle commented Nov 26, 2021

With some words explaining why the example can be useful.
Could be used to have a few examples of "tough but constructive" reviews for instance.
The list would clearly state it's not exhaustive.

@maelle maelle added this to the 0.8.0 milestone Nov 26, 2021
@noamross
Copy link
Contributor

One good tough-but-constructive example: the part of this review suggesting a re-write of the vignette: ropensci/software-review#191 (comment)

@mpadge
Copy link
Member

mpadge commented Nov 29, 2021

Another good example is for the slopes package, which ended up being fundamentally redesigned in response to the reviews. All reviews/reviewers were at all times entirely constructive, which seems to have played a major role in motivating the authors to embark on such a major overhaul. Comments such as, "this package does not ..." or "has not ..." were invariably followed by constructive suggestions for what could be done (there are, for example, several in one of the first reviews).

@maelle maelle mentioned this issue Nov 30, 2021
@maelle maelle linked a pull request Jan 10, 2022 that will close this issue
@maelle maelle closed this as completed Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants