Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geojsonio seems vulnerable to PROJ 6 #148

Closed
rsbivand opened this issue Apr 24, 2019 · 5 comments
Closed

geojsonio seems vulnerable to PROJ 6 #148

rsbivand opened this issue Apr 24, 2019 · 5 comments

Comments

@rsbivand
Copy link

I'm running reverse dependency checks using sf from github adapted not to fail with PROJ 6 sf_0.7-4, and CRAN rgdal also adapted not to fail with PROJ 6 rgdal_1.4-3, but see that geojsonio fails with PROJ 6. The failures are deep inside testthat, so opaque. I attach the compressed R CMD check files (R 3.5.3).
failing_check.zip.

Could you please check on a system instance with PROJ 6? When PROJ 7 hits us in 10 months, sf and rgdal will follow, while trying to keep backward compatibility. The current adaptations are enough to keep things running with the completely revised projection metadata storage systems, but more changes will follow, diverging more from legacy.

@sckott
Copy link
Collaborator

sckott commented Apr 24, 2019

Thanks, I'll have a look. All of those validate tests are a non-issue now as that function is now defunct in the development version and it's tests removed.

Is there a recommended way to use a particular version of PROJ on macos?

@rsbivand
Copy link
Author

Thanks!

Sorry, have no OSX access, so can't check. PROJ has some hints here: https://proj4.org/install.html#install, untried. There may also be non-PROJ issues at my end because I was running the github master of sf and get different outcomes from Edzer, so instability is a more fitting description than an identified problem. PROJ is going to be unstable for some time, but that's mostly because it wasn't actively maintained for some years.

@sckott
Copy link
Collaborator

sckott commented Apr 24, 2019

thanks. i'll have a look

@sckott
Copy link
Collaborator

sckott commented Nov 27, 2019

Closing this. errors were only related to the validate fxn, which is now defunct

@sckott sckott closed this as completed Nov 27, 2019
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants