-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add angle as filter #529
Add angle as filter #529
Conversation
Looks good, thanks @wangzhao0217 . Problem: GitHub Actions are failing. Can you test on this branch with devtools::check() ? If you pull down the latest version from the master branch you can test it works: please confirm |
Update on this: I've had a look to try to diagnose the issue. It seems that you are calling functions from the See here: https://github.com/ropensci/stplanr/actions/runs/6171414373/job/16749592822#step:6:46 |
vignettes/merging-route-networks.Rmd
Outdated
@@ -17,11 +17,12 @@ knitr::opts_chunk$set( | |||
message = FALSE, | |||
warning = FALSE | |||
) | |||
devtools::load_all() | |||
# devtools::load_all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 that should solve it
Hi @wangzhao0217 here's another suggestion that should be a quick fix to get actions passing: devtools::document() |
Closed in favour of #530 |
Hi Robin,
Sorry I forgot to create the PR to let you review.
Please have a look at this latest version with the following changes:
Here is the result.