-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tar_renv #170
Added tar_renv #170
Conversation
|
Still one more lint complaint at https://github.com/wlandau/targets/pull/170/files#diff-2952800a4992b3e5427b2bad378bfd3fR31 I think this one is unavoidable... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is off to a great start, thanks for contributing. I know I have a lot of comments, but they are all minor.
By the way, feel free to add yourself as a contributor in the DESCRIPTION
file, e.g. person(given = "Matthew", family = "Warkentin", role = "ctb")
.
Also, don't worry about the check note in #170 (comment). That one is truly unavoidable. |
Thanks for all the comments! No sirens went off this time, so I must be learning how to do all my checks BEFORE committing the code. |
Looks great, thanks for your work. |
Thanks for allowing me to go through this process. You probably spent more time reviewing my code than it would've taken you to implement this feature yourself, so I do appreciate it. |
Prework
Summary
Add the
tar_renv()
function and documentation as discussed in #157. PR also includes unit tests and the addition oftar_renv
to_pkdgown.yml
.Related GitHub issues and pull requests
Checklist