From c2bee139715463959e23b353d51542425767e15b Mon Sep 17 00:00:00 2001 From: msperlin Date: Wed, 23 Nov 2022 17:29:44 -0300 Subject: [PATCH] now using tidyselect::all_of -- fixes #22 --- DESCRIPTION | 5 +++-- NEWS.md | 4 ++++ R/yf_data_convert_to_wide.R | 2 +- inst/WORDLIST | 1 + 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index e369b97..77d3316 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: yfR Title: Downloads and Organizes Financial Data from Yahoo Finance -Version: 1.0.4 +Version: 1.0.5 Authors@R: c(person("Marcelo", "Perlin", email = "marceloperlin@gmail.com", role = c("aut", "cre")), person("Nic", "Crane", role = "rev", comment = "Nic reviewed the package (v. 0.0.5) for @@ -34,7 +34,8 @@ Imports: magrittr, humanize, methods, - pingr + pingr, + tidyselect License: MIT + file LICENSE LazyData: true RoxygenNote: 7.2.2 diff --git a/NEWS.md b/NEWS.md index 2ea4479..d4d008a 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +## Version 1.0.5 (2022-11-23) -- bug fixes + +- now using tidyselect::all_of() (fixes [issue #22](https://github.com/ropensci/yfR/issues/22)) + ## Version 1.0.4 (2022-11-15) -- bug fixes - switched curl::has_internet by pingr::is_online() -- the first doesn't seem to work on restricted networks. Fixes [#20](https://github.com/ropensci/yfR/issues/20) diff --git a/R/yf_data_convert_to_wide.R b/R/yf_data_convert_to_wide.R index fcf496e..cfb3624 100644 --- a/R/yf_data_convert_to_wide.R +++ b/R/yf_data_convert_to_wide.R @@ -32,7 +32,7 @@ yf_convert_to_wide <- function(df_in) { temp_df_wide <- tidyr::pivot_wider( data = temp_df, names_from = ticker, - values_from = tidyr::all_of(name_in) + values_from = tidyselect::all_of(name_in) ) return(temp_df_wide) diff --git a/inst/WORDLIST b/inst/WORDLIST index 1a8d5d0..a9340fe 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -49,3 +49,4 @@ dontrun donttest TSLA pingr +tidyselect