Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only check line after Contributors if it exists #41

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 17, 2024

Fixes #40

Also combines the two checks into one as they have the same outcome.

@mpadge
Copy link
Member

mpadge commented Jul 17, 2024

Thanks so much @sbfnk. I was just working on solution myself. I think it's safer just to wrap the current lines:
https://github.com/ropenscilabs/allcontributors/blob/d9ce29682297494e40f26e3a257967a08ef2add3/R/add-contributors.R#L333-L338

in a single if (contribs_sec < length (x)) {...}. Could you please make that modification? Then I'll happily merge. Thanks for improving the package!

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 17, 2024

OK -- done!

@mpadge mpadge merged commit fcfee65 into ropensci:main Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_contributors fails if ## Contributors is the last line of README.Rmd
2 participants