Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add clock interface in the filters? #162

Open
destogl opened this issue Aug 17, 2023 · 0 comments
Open

How to add clock interface in the filters? #162

destogl opened this issue Aug 17, 2023 · 0 comments

Comments

@destogl
Copy link
Member

destogl commented Aug 17, 2023

          Unless the filter_base is changed, I don't think the filter has any access to the node (only its logger and parameter interfaces). Maybe the filter should get a time and dt passed when updated (as controllers do)

Originally posted by @guihomework in #153 (comment)

There are 2 options I can see right now:

  1. Change FilterBase and FilterChainBase to support this argument in the configure()
  2. Add override of the FilterBase and FilterChainBase classes and enable controllers to use it instead of the generic filters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant