Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LowPassFilter accepts parameters only from node #164

Open
roncapat opened this issue Oct 9, 2023 · 2 comments · May be fixed by #192
Open

LowPassFilter accepts parameters only from node #164

roncapat opened this issue Oct 9, 2023 · 2 comments · May be fixed by #192

Comments

@roncapat
Copy link
Contributor

roncapat commented Oct 9, 2023

I wanted to use LowPassFilter, but it seems to me that there is no way to pass parameters via API (like PID constructor or setGains() call).

Wouldn't be better to make LowPassFilter support parameter passing via API and a corresponding LowPassFilterROS querying parameters from configuration instead?
Or just modifying LowPassFilter to support both scenarios...

I would contribute a PR following your feedbacks of course.

@CalaW
Copy link

CalaW commented Feb 25, 2024

I think it is possible to change the parameters at runtime using this->set_parameter. Similar to

node_->set_parameter(rclcpp::Parameter("sampling_frequency", 500.0));

@christophfroehlich
Copy link
Contributor

I support the idea of a base implementation without ROS, and then being wrapped in the filters-class with the ROS node interfaces.
@roncapat Even if your idea is a few months old, I'd welcome a PR.

@roncapat roncapat linked a pull request Mar 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants