You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to use LowPassFilter, but it seems to me that there is no way to pass parameters via API (like PID constructor or setGains() call).
Wouldn't be better to make LowPassFilter support parameter passing via API and a corresponding LowPassFilterROS querying parameters from configuration instead?
Or just modifying LowPassFilter to support both scenarios...
I would contribute a PR following your feedbacks of course.
The text was updated successfully, but these errors were encountered:
I support the idea of a base implementation without ROS, and then being wrapped in the filters-class with the ROS node interfaces. @roncapat Even if your idea is a few months old, I'd welcome a PR.
I wanted to use
LowPassFilter
, but it seems to me that there is no way to pass parameters via API (likePID
constructor orsetGains()
call).Wouldn't be better to make
LowPassFilter
support parameter passing via API and a correspondingLowPassFilterROS
querying parameters from configuration instead?Or just modifying LowPassFilter to support both scenarios...
I would contribute a PR following your feedbacks of course.
The text was updated successfully, but these errors were encountered: